From bda90e2ab5203feb938188cbd8e029c9b2a467db Mon Sep 17 00:00:00 2001 From: Rob Browning Date: Sat, 29 Jul 2017 11:50:27 -0500 Subject: [PATCH] Don't downcase real xref in elisp-mode-tests The elisp-mode-tests should no longer fail on case sensitive filesystems when the build path contains uppercase characters. Previously the code was downcasing the path for both comparison and lookups. --- test/lisp/progmodes/elisp-mode-tests.el | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/test/lisp/progmodes/elisp-mode-tests.el b/test/lisp/progmodes/elisp-mode-tests.el index 941e85bc890..faf45b88ff7 100644 --- a/test/lisp/progmodes/elisp-mode-tests.el +++ b/test/lisp/progmodes/elisp-mode-tests.el @@ -301,11 +301,15 @@ (defun xref-elisp-test-run (xrefs expected-xrefs) (should (= (length xrefs) (length expected-xrefs))) (while xrefs - (let* ((xref (pop xrefs)) + (let* ((real-xref (pop xrefs)) + (xref (clone real-xref)) (expected (pop expected-xrefs)) (expected-xref (or (when (consp expected) (car expected)) expected)) (expected-source (when (consp expected) (cdr expected)))) + (setf (oref xref location) + (copy-xref-elisp-location (oref xref location))) + ;; Downcase the filenames for case-insensitive file systems. (setf (xref-elisp-location-file (oref xref location)) (downcase (xref-elisp-location-file (oref xref location)))) @@ -315,7 +319,7 @@ (should (equal xref expected-xref)) - (xref--goto-location (xref-item-location xref)) + (xref--goto-location (xref-item-location real-xref)) (back-to-indentation) (should (looking-at (or expected-source (xref-elisp-test-descr-to-target expected))))) -- 2.30.2